chore: codebase audit, graceful shutdown, doc cleanup - #36
Merged
Conversation
- add graceful shutdown on SIGINT/SIGTERM with connection draining - fix all rustdoc warnings (escape angle brackets and square brackets in command doc comments across 56 doc strings) - fix clippy range check warnings in test assertions - add fsync after AOF truncate header rewrite for durability - update all crate READMEs to reflect current feature set (hashes, sets, cluster commands, graceful shutdown) - remove stale "WIP" labels from related crate tables - update CLAUDE.md command count from 49 to 62
kacy
added a commit
that referenced
this pull request
Feb 11, 2026
chore: codebase audit, graceful shutdown, doc cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
full codebase audit across all 6 crates (ember-server, ember-core, ember-protocol, ember-persistence, ember-cluster, ember-cli). 574 tests pass, clippy clean, zero doc warnings.
fixes from the audit:
documentation updates:
what was tested
cargo test --workspace— 574 tests pass, 0 failurescargo clippy --workspace -- -D warnings— zero warningscargo doc --workspace --no-deps— zero warnings (was 30+)cargo fmt --all --check— cleandesign considerations
graceful shutdown: uses
tokio::select!withbiasedto prioritize the shutdown signal over new accepts. drains by acquiring all semaphore permits (each connection releases its permit on exit). simple, no new dependencies, no broadcast channels needed.AOF truncate fsync: the truncate method now calls
sync_all()after flushing the fresh header. this closes a durability window where a crash between truncate and the next write could leave an unsynced header on disk.doc comment style: switched from
<angle>syntax (interpreted as HTML) to`backtick`syntax for parameters and\[escaped\]for optional flags. consistent across all 62 commands.